Hi all,
Looking for a code review of the proposed changes for
the fix for bug #8048:
http://defect.opensolaris.org/bz/show_bug.cgi?id=8048
image update doesn't check to see if specified be-name already exists
Webrev is at:
http://cr.opensolaris.org/~richb/pkg-8048-v1/
I initially looked at overloading the InvalidBENameException
with an additional "message" parameter (default value of None),
which could be an alternate message.
The problem there was that check_be_name is a static method
(and I believe needs to be because of the way it's called in the
public API in api.py). In the end, I went for a new BE exception
BENameExistsException and added additional code into the
check_be_name method in bootenv.py.
I don't like that it replicates code that's in the class __init__
method, but I can't see another way of doing this because it's a
static method.
Brock (or others), maybe you can suggest a better approach...
Thanks.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
