Shawn Walker wrote:
...
Webrev is at: http://cr.opensolaris.org/~richb/pkg-8048-v1/
modules/client/api_errors.py:
line 442: I'd suggest DuplicateBE() (or DuplicateBEName()?) for the
name of the exception
Of those two, I prefer the second one, but it does raise a question.
Why do some of the exceptions have Exception as part of their name
and others don't? Just trying to understand the reasoning here...
line 443: docstring please
Okay.
modules/client/bootenv.py:
lines 203-205: I think there's a much simpler way to do this
(untested):
if be_name and be_name in (be.get("orig_be_name") for be in beList):
I'll give it a try.
Thanks.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
