Rich Burridge wrote:
Hi all,
Looking for a code review of the proposed changes for
the fix for bug #8048:
http://defect.opensolaris.org/bz/show_bug.cgi?id=8048
image update doesn't check to see if specified be-name already exists
Webrev is at:
http://cr.opensolaris.org/~richb/pkg-8048-v1/
modules/client/api_errors.py:
line 442: I'd suggest DuplicateBE() (or DuplicateBEName()?) for the
name of the exception
line 443: docstring please
modules/client/bootenv.py:
lines 203-205: I think there's a much simpler way to do this (untested):
if be_name and be_name in (be.get("orig_be_name") for be in beList):
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
