Danek Duvall wrote:
On Wed, Apr 22, 2009 at 11:36:56AM -0700, Rich Burridge wrote:
http://cr.opensolaris.org/~richb/pkg-8048-v1/
api_errors.py:
- line 448: the _() should just be around the static string, not the
expando argument.
Yup.
bootenv.py:
- check_be_name is inconsistent in what it does. If BE naming doesn't
make sense, then it throws an exception, but otherwise, it returns a
boolean value, or it raises an exception. In the calling code, if it
returns false, it always raises an exception.
My suggestion is that check_be_name always either returns nothing, or
raises an exception. Where it would return False now, raise the
exception that the calling code current raises. Thus the behavior of
the calling code is: just call it and if it returns, then we can
continue.
Wouldn't that then require an inconsistent API change to the
check_be_name method in api.py ?
@staticmethod
def check_be_name(be_name):
return bootenv.BootEnv.check_be_name(be_name)
Just checking that that is okay. No biggie to me.
Thanks.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
