[email protected] wrote:
Webrev is at:

http://cr.opensolaris.org/~richb/pkg-8030-v1/

src/util/distro-import/unbundleds/GnuDevTools

    Line 9 - I don't believe a dependency on SUNWgcmn is warranted
    here.

George and I had previously discussed this. There is a line in
the SVR4 depend file:

 P SUNWgcmn     Common GNU package

for SUNWgcc432 for this package and I was asked to include a
dependency for it. George, can you please  confirm that it is
needed (and if so, what for)?

    Also, isn't the dependency on SUNWgccruntime432 determined
    automatically?

Surprisingly not. The following dependencies are found automatically:

SUNWgcc432 add depend require [email protected]
SUNWgcc432 add depend require [email protected]
SUNWgcc432 add depend require [email protected]
SUNWgcc432 add depend require [email protected]

SUNWgccruntime432 add depend require [email protected]
SUNWgccruntime432 add depend require [email protected]


    Line 20 - There should be a classification and a description
    added to the cluster.  Something along the lines of

    classification "Development/Integrated Development Environments"
    description "GNU Compiler Collection 4.3.2 Development cluster"

Okay (for the description). Are we agreed that this should be a new:

 "Development/Suites"

?

Should I retro-fit gcc-dev to also be so classified?


    Also, we don't typically version the clusters under the
    unbundled directory.  Perhaps that's a bug in itself but
    calling out a version here is at odds with the other clusters
    so I would suggest deleting line 20 for now.

Okay.

    The corresponding "gcc-dev" cluster depends on quite a few
    other components useful from a developer point of view.  Seems
    these should be included here as well.

These would be:

depend SUNWaconf
depend SUNWbison
depend SUNWcvs
depend SUNWflexlex
depend SUNWgcc             <== developer/gnu/gcc-dev-4
depend SUNWgdb
depend SUNWgmake
depend SUNWgnu-automake-110
depend SUNWgnu-automake-19
depend SUNWlibtool
depend SUNWmercurial
depend SUNWsprot
depend SUNWsvn

So developer/gnu/gcc-dev-4 would equate to just SUNWgcc
above. Should it be called developer/gnu/gcc-4 instead and
developer/gnu/gcc-dev-4 would bundle it up with all the others?
That certainly wasn't what was requested on the original
project checklist). George, what would you like to see happen here?

If we do bundle it up, can it then simply be classified as

"Development/Integrated Development Environments"

?

When I get replies to these questions, I'll generate a new webrev.

Thanks.

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to