On Thu, May 07, 2009 at 02:11:17AM -0700, Dan Price wrote:
> > >http://cr.opensolaris.org/~dp/pkg-zonefixes3/
>
> Webrev is reposted
Looks fine to me; just a few nits.
attach:
- line 425: is GZ_IMAGE something you'd expect to set from outside the
script? If not, I'm not sure I understand its purpose.
- line 455: You might have a comment here saying you're resetting
PKG_IMAGE now that you're done collecting information. You also don't
need the second export call, though it won't hurt.
- Is it worth checking that either both the key and the cert are None or
neither is?
common.ksh:
- line 163,166: no need for backslashes. Or square brackets around the
single space (did you mean for that to be space and tab?).
- line 164: funny indentation (space tab space)
pkgcreatezone:
- line 260 et al: you can put the $() construct inside the double quotes,
which will look more natural.
- line 275: You could create the image with --no-refresh earlier, copy
the keys in, and then do a refresh here ...
client.py:
- line 1665: no need to pass in img_dir if you're passing img, right?
- line 1794, 1795: do you need abspath() here? Do you really expect
img.root not to be absolute? And probably should use os.path.join()
here, too.
imageconfig.py:
- line 156: So this isn't the case in general -- it's specific to zones,
and hopefully we'll make that difference go away in the next release.
- line 281: why str()?
- line 471, 483: no need for backslashes.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
