On Thu 07 May 2009 at 06:40PM, Shawn Walker wrote:
> Dan Price wrote:
> >http://cr.opensolaris.org/~dp/pkg-zonefixes3/ [new webrev]
>
> General comment:
> Should these scripts explicitly set umask 0022 to avoid possible
> problems with the pkg client, etc.?
I belive the zone framework does so.
> modules/client/image.py:
> line 302: you shouldn't need this; it should be sufficient to just
> call read as you do on the next line
Are you sure? It seems like imageconfig's read doesn't take care to
dump everything out of its internal view of the world before reading.
We'll get away with it in this case, but it doesn't seem safe in
general.
> src/brand/pkgcreatezone:
> line 138: do you still need the -R / given that PKG_IMAGE is set?
Sure, nuked.
> lines 259-271: should the cert/key files be explicitly set to 644?
Will do, and in attach.
> Last thought:
> What is the user has an http_proxy or https_proxy enviroment viarable
> set in the global zone? Should that be propagated somehow?
I don't know. Let's call it a problem for another day.
-dp
--
Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
