Dan Price wrote:
On Wed 06 May 2009 at 10:16PM, Dan Price wrote:
Here is my first cut at the zones + ssl repo = problems bug.
Please take a look. There is still some debug stuff in there, but
I want feedback on the approach. Many thanks to Bart who helped
me work out some somewhat ugly but hopefully low-risk changes to our
python to make this work more elegantly.
-dp
http://cr.opensolaris.org/~dp/pkg-zonefixes3/
Ok-- I have incorporated the feedback I got, and did more testing.
I have posted:
http://cr.opensolaris.org/~dp/pkg-zonefixes3.old/ [previous webrev]
http://cr.opensolaris.org/~dp/pkg-zonefixes3/ [new webrev]
http://cr.opensolaris.org/~dp/pkg-zonefixes3.diffs/ [diffs webrev]
Notable changes:
- The old wad seemed likely to suffer from a bug where the
changes in imageconfig wouldn't work on older (pre-variant
zones). I made a change in image.py to cope with this which
seemed safe and sane, but needs review.
- Fixed stupid bug in safe_copy.
- Codereview feedback incorporated.
Thanks,
-dp
I looked at the python code, those changes all looked fine to me. My ksh
abilities are lacking, so I'll let others review those changes.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
