Dan Price wrote:
http://cr.opensolaris.org/~dp/pkg-zonefixes3/ [new webrev]
General comment:
Should these scripts explicitly set umask 0022 to avoid possible
problems with the pkg client, etc.?
modules/client/image.py:
line 302: you shouldn't need this; it should be sufficient to just
call read as you do on the next line
src/brand/pkgcreatezone:
line 138: do you still need the -R / given that PKG_IMAGE is set?
lines 259-271: should the cert/key files be explicitly set to 644?
Last thought:
What is the user has an http_proxy or https_proxy enviroment viarable
set in the global zone? Should that be propagated somehow?
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
