Dan Price wrote:
On Thu 07 May 2009 at 06:40PM, Shawn Walker wrote:
Dan Price wrote:
modules/client/image.py:
line 302: you shouldn't need this; it should be sufficient to just
call read as you do on the next line
Are you sure? It seems like imageconfig's read doesn't take care to
dump everything out of its internal view of the world before reading.
We'll get away with it in this case, but it doesn't seem safe in
general.
I'll put it this way: read() should be sufficient, and if it isn't;
there's a bug. If read() really should be resetting everything like
__init__ does, then it needs to be changed.
*However*, what you're doing now "shouldn't break" either. So, it is
probably safest to leave it as is, though perhaps not "optimal."
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
