p5i.py:
Lines 161-164: I don't really understand this comment.
194-203: is there any reason we might want to keep the items in this
list associated with their particular repositories? maybe they are and I
just don't realize it, but I'm confused as to how, for example, a mirror
would work w/out knowing which repo it mirrored
server/depot.py:
line 53: is there a way to do this w/out importing a client module? So
far, we've had a very clean separation between client-only, server-only,
and shared code. I'd like to continue this going forward as it'll make
splitting SUNWipkg up into client and server packages much easier. If
this is a hack to keep the level of change low and get it in before the
gate closes, I'm fine w/ that but please file a bug then to refactor the
code as necessary.
896: couldn't this be 'if "*" not in pfmri'?
900: I think the try block from 876-884 could be moved inside here
Filing a bug to remove the hacks related to packagemanager's requirement
of the p5i file extension would be nice.
Other than that, looks good,
Brock
Shawn Walker wrote:
Shawn Walker wrote:
Greetings,
The following webrev contains the changes necessary to implement
these RFEs:
7862 install links using p5i for search results desired
8723 repository should contain publisher and repository client
metadata
8724 publisher metadata retrieval operation desired
webrev:
http://cr.opensolaris.org/~swalker/pkg-8724/
Please note I do need two reviewers for this as soon as possible so I
can make Monday's cutoff.
Thanks,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
