Shawn Walker wrote:
Brock Pytlik wrote:
p5i.py:
Lines 161-164: I don't really understand this comment.
In short, the output data structure is a giant dict that looks
something like:
publishers: {
'foo': {
'packages': ["bar", "baz"],
},
},
...so because of that, is not only unnecessary, but undesirable to
embed the publisher information into the FMRI.
Ah, that helps me understand what's going on.
194-203: is there any reason we might want to keep the items in this
list associated with their particular repositories? maybe they are
and I just don't realize it, but I'm confused as to how, for example,
a mirror would work w/out knowing which repo it mirrored
I'm a little lost as to what you mean by "associated with their
particular repositories". The code is adding an array of repositories
that belong to a specific publisher underneath the publisher's dict
entry.
Probably didn't understand the overall structure the info was getting
dumped into.
server/depot.py:
line 53: is there a way to do this w/out importing a client module? So
Not currently; pkg.client.publisher really should have been
pkg.publisher, that was my mistake.
far, we've had a very clean separation between client-only,
server-only, and shared code. I'd like to continue this going forward
as it'll make splitting SUNWipkg up into client and server packages
much easier. If this is a hack to keep the level of change low and
get it in before the gate closes, I'm fine w/ that but please file a
bug then to refactor the code as necessary.
Essentially. pkg.client.publisher should really be pkg.publisher and
pkg.client.api_errors needs a lot of its errors moved to
pkg.api_errors as they are often common between server and client.
Figured it was something like that. Can we get a bug filed for this?
Filing a bug to remove the hacks related to packagemanager's
requirement of the p5i file extension would be nice.
They've already done that.
Sorry, I meant the hacks in your code to handle the fact that package
manager requires the .p5i to be at the end of the file name. I saw a
couple places with XXX comments.
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
