On Tue, May 26, 2009 at 9:10 PM, Shawn Walker <[email protected]> wrote: > Martin Bochnig wrote: >> >> Yes, no: There exists a problem. Not sure if it is based on a typo by >> you, or the www client I use (FF3.1b3). >> >> On http://cr.opensolaris.org/~swalker/pkg-9164/ >> the contained links contain all a single "\'" at their end, where it >> shouldn't be. >> If at all, it should probably be a matching pair such as one ' at the >> front and a matching ' at the end? > > This is a bug with webrev/GNU sed. I've regenerated it after changing my > environment so webrev will use /usr/bin/sed. Sigh. > > -- > Shawn Walker
Ok, all 3 files look good to me. Only some thoughts about one of them (which has the most changes) : http://cr.opensolaris.org/~swalker/pkg-9164/src/tests/api/t_misc.py.udiff.html Thought #0.) It seems that one line was erroneously inserted twice, in: + self.assertFalse(misc.valid_pub_url("!...@#$%^&*(*)")) + self.assertFalse(misc.valid_pub_url("!...@#$%^&*(*)")) + self.assertTrue(misc.valid_pub_url( + "http://pkg.opensolaris.org/dev";)) + + Thought #1.) When speaking of the criteria that make both misc.valid_pub_prefix and misc.valid_pub_url match, aren't there further chars as well, which should be added, such as '~' ? I mean the shell prevents the user from entering stuff like single- or double-quotes in wrong places. And also the Tilde has a special meaning for Bourne as well as C- compatible shells. Therfore my question: I'm not sure whether '~' (or something else) should be added to self.assertFalse(misc.valid_pub_prefix()) and self.assertFalse(misc.valid_pub_url()), or not. Just let's think about it. Thought #2.) Generally speaking, do you think it is a good idea to hardwire URL's into actual code? I need to catch up with IPS's rapid development (after more than a year of a break in terms of actually browsing through the IPS src). Is there a placeholder which could already replace a hardwired reference such as http://pkg.opensolaris.org/dev, or does it still need to be introduced? Cheers, %martin bochnig _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
