Martin Bochnig wrote:
Thought #1.) When speaking of the criteria that make both misc.valid_pub_prefix and misc.valid_pub_url match, aren't there further chars as well, which should be added, such as '~' ?
Changing what characters are allowed is beyond the scope of this webrev. This webrev is only to fix the issue with None and add unit tests.
I agree that the valid_pub_* tests here are restrictive, but I'm not the one that created them.
Thought #2.) Generally speaking, do you think it is a good idea to hardwire URL's into actual code?
These are just unit tests, so the URI doesn't matter. No actual network connection is performed so there is no need to be concerned. I just needed something syntactically valid.
Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
