On Tue, May 26, 2009 at 9:46 PM, Shawn Walker <[email protected]> wrote: > Martin Bochnig wrote: >> >> Thought #1.) >> When speaking of the criteria that make both misc.valid_pub_prefix and >> misc.valid_pub_url match, aren't there further chars as well, which >> should be added, such as '~' ? > > Changing what characters are allowed is beyond the scope of this webrev. > This webrev is only to fix the issue with None and add unit tests. > > I agree that the valid_pub_* tests here are restrictive, but I'm not the one > that created them. > >> Thought #2.) >> Generally speaking, do you think it is a good idea to hardwire URL's >> into actual code? > > These are just unit tests, so the URI doesn't matter. No actual network > connection is performed so there is no need to be concerned. I just needed > something syntactically valid. > > Cheers, > -- > Shawn Walker >
And thought #0.), why didn't you comment? > http://cr.opensolaris.org/~swalker/pkg-9164/src/tests/api/t_misc.py.udiff.html > > Thought #0.) > > It seems that one line was erroneously inserted twice, in: > > + self.assertFalse(misc.valid_pub_url("!...@#$%^&*(*)")) > + self.assertFalse(misc.valid_pub_url("!...@#$%^&*(*)")) > + self.assertTrue(misc.valid_pub_url( > + "http://pkg.opensolaris.org/dev";)) > + > + Like everyone I make a million mistakes myself every day. Maybe this message is one of them. But I can and do admit this/them (maybe the biggest mistake of all!!). Aren't we a family here? Maybe I'm naive. Or maybe I have unrealistic expectations from world. Maybe I should myself join 96% of the population and never ever - implicitly or explicitly - admit any small typo or whatever. Cheers, Martin Bochnig http://www.facebook.com/people/Martin-Bohnig-Martin-Bochnig/1712478141 _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
