On Jun 17, 2009, at 11:34 AM, Danek Duvall wrote:
On Wed, Jun 17, 2009 at 11:12:37AM -0500, Shawn Walker wrote:
http://cr.opensolaris.org/~swalker/README
line 37, et al: -r is redundant with -a, and -z is probably a waste
of CPU
for this case.
You talk about putting these images on optical media, but never
suggest
how.
That was an exercise I was going to leave to the reader, but I can
include it if so desired.
line 90: <data_source> would be "/destination" from the examples in
sections 2.1 and 2.2?
I used <data_source> since /destination only applies if you copied it
somewhere. If you mounted the image directly, /destination would not
apply.
line 90: You also suddenly start using pfexec here, where none of the
previous commands have it. I'd skip it and put some text up top
saying
that it should be used, or that the commands should be run as root. I
think there's a decent chance that these instructions will be
followed on a
machine that isn't running OpenSolaris and/or doesn't have pfexec
set up
for the user.
If it isn't running OpenSolaris, there's a good chance the mount
instructions won't work either.
If they are running OpenSolaris, pfexec is setup by default, and only
wouldn't be if they had changed configuration.
Nevertheless, I'm fine with saying that the commands should be
executed as root or using 'pfexec'.
line 101: You switch to cfg_cache modification here, in between a
bunch of
svccfg invocations. It might make sense to keep them all together.
I've slightly re-ordered this.
line 115: why give the example in the text body *and* the example in
the
offset text on line 117, *and* have them be different?
Because one is for when there is a port number, and one is not. I
didn't want users to specify :80 and I thought
<:port_number_if_different_than_80> seemed silly. I've reworded this
as:
(if you changed the port number above, you would include it
using :<port_number>, after '.com' in the example below):
http://cr.opensolaris.org/~swalker/cfg_cache
line 7: since the README primarily suggests setting the depot up as an
origin server, calling it a mirror here doesn't seem right. Same on
line
28, I guess.
I think that's just semantics really, since it can be used as a
"mirror" in either case. What differentiation here would make this
distinction satisfactory or clearer?
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
