On Thu, Jul 30, 2009 at 06:45:10PM -0700, Dan Price wrote:
> http://cr.opensolaris.org/~dp/pkg-action-fixes/
directory.py:
- Other than the wording changes, I'm ambivalent about the changes here.
If you think it's cleaner somehow, that's fine, but otherwise, they're
unnecessary.
link.py:
- line 97: os.path.exists() does a stat(), not an lstat(), so I don't
think this does what you want. You probably want to do a single
lstat() call, and check first that the pathname exists and second that
it's a symlink.
- line 98, 100: while I understand the difference between the messages,
why does one have the pathname, and the other not? Should the second
message be "Not a symbolic link"? That's how the directory action
treats the same problem. But a file action says "%s is not a regular
file".
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
