On Mon 03 Aug 2009 at 11:14AM, Danek Duvall wrote:
> On Fri, Jul 31, 2009 at 07:35:36PM -0700, Dan Price wrote:
>
> > http://cr.opensolaris.org/~dp/pkg-action-fixes/
>
> Looks nice. Just a few nits, except for the link attributes bit.
>
> generic.py:
>
> - line 435: perhaps "Unknown filesystem object ()"?
If I do that, then in context, this will be:
File Type: 'Unknown filesystem object (0xf000)' should be 'directory'
Seemed to me that:
File Type: 'Unknown (0xf000)' should be 'directory'
is more clear.
> - line 439, etc: isn't this going to crap out on links?
I'm lost: why would it crap out, exactly? The code sez:
if "mode" in self.attrs:
mode = int(self.attrs["mode"], 8)
So... link actions don't have the mode attr, so this will
not run for them... right?
> - line 453, 469, 473, 478: no continuation character
It is supremely annoying that there isn't a checker for this.
Besides you. Can pylint be programmed to tell me this?
> - line 471, 475: why go back through the lookup when this data is already
> in the action?
I'm not sure-- that's the way the code was in the file/dir/etc. action.
I changed it and will see if it works out.
> hardlink.py:
>
> - line 94: since we only allow hardlinks to files, why not stat.IS_REG
> here?
I didn't think of that (and I think the old code didn't either). Fixed,
with a comment added.
> - line 105, 115: no continuation character
Fixed.
-dp
--
Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
