On Fri, Jul 31, 2009 at 07:35:36PM -0700, Dan Price wrote:
> http://cr.opensolaris.org/~dp/pkg-action-fixes/
Looks nice. Just a few nits, except for the link attributes bit.
generic.py:
- line 435: perhaps "Unknown filesystem object ()"?
- line 439, etc: isn't this going to crap out on links?
- line 453, 469, 473, 478: no continuation character
- line 471, 475: why go back through the lookup when this data is already
in the action?
hardlink.py:
- line 94: since we only allow hardlinks to files, why not stat.IS_REG
here?
- line 105, 115: no continuation character
link.py:
- line 106: no continuation character
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
