On Mon, Aug 03, 2009 at 01:29:45PM -0700, Dan Price wrote: > > - line 435: perhaps "Unknown filesystem object ()"? > > If I do that, then in context, this will be: > > File Type: 'Unknown filesystem object (0xf000)' should be 'directory' > > Seemed to me that: > > File Type: 'Unknown (0xf000)' should be 'directory' > > is more clear.
Not to me, but get other opinions if you like. It can always be changed if people find it weird. > > - line 439, etc: isn't this going to crap out on links? > > I'm lost: why would it crap out, exactly? The code sez: > > if "mode" in self.attrs: > mode = int(self.attrs["mode"], 8) > > So... link actions don't have the mode attr, so this will > not run for them... right? Right; sorry. I spaced out and didn't see the test. > > - line 453, 469, 473, 478: no continuation character > > It is supremely annoying that there isn't a checker for this. > Besides you. Can pylint be programmed to tell me this? No idea. > > - line 471, 475: why go back through the lookup when this data is already > > in the action? > > I'm not sure-- that's the way the code was in the file/dir/etc. action. > I changed it and will see if it works out. Okay; either way. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
