Ed,

Thanks for reviewing this.

Edward Pilatowicz wrote:
----------
src/brand/smf_disable.lst

- so 6859248 went back on wed.
  doesn't that make the entries in this file unnecessary?

I'll take a look at that change and see about rewriting the
code to incorporate that fix instead of what we're currently
doing.


----------
src/brand/pkgcreatezone

- in the usage message, how is it possible to have arguments after -e
  since -e takes a variable number of arguments?

No, it doesn't, -e takes one pkg name argument.  You need to use
multiple -e options to specify multiple pkgs.  We could try to
clarify the usage message if you have a suggestion.

- after a normal zone install, this script prints:
        printf "$m_complete\n\n" ${SECONDS}
  but if you install from an image, you print:
        printf "$m_done\n"
  why the difference?

I'll make them the same.


----------
src/brand/p2v

- acording to the comments, the zoneadm attach -U will result in the
  zone being marked "installed".  if the install process is interrupted
  after this, then we may end up with an installed zoned that's not
  fully p2v'd.  hence it seems to me that we might want an additional
  flag to pass to the attach that tells it not to transition the zone
  to the installed state.  (this could be done after your initial p2v
  putback, since it requires a change in nevada.)

I'll file a bug to track that in nv.

Thanks again for reviewing this,
Jerry


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to