On Thu, Nov 05, 2009 at 12:29:09PM -0700, Jerry Jelinek wrote: > I have an updated webrev for the ipkg-branded zone p2v > which addresses the code review comments from a couple > months ago. > > The changes include using the new facilities in SMF to > delete global zone-only svcs by removing their manifests. > The new code is in the fix_smf() function in the p2v file. > As a result of this, I no longer boot the zone during > p2v and instead mount the zone to make all the adjustments > during the p2v process. > > In addition, I've updated the brand code to make it more > similar to the solaris10 brand code in ON and I've also > updated the code to re-use the new common code that was > putback for the solaris10 brand into ON. > > The updated webrev is at: > > http://cr.opensolaris.org/~gjelinek/webrev.6793/ > > Thanks, > Jerry >
thanks for updating this to use the common code. wrt smf_disable.lst, it seems like this file should be empty to me. looking at the current services in this file, it seems like they are services which should never exist within a zone, not just be disabled within a zone. so if these services shouldn't exist within a zone, then the smf manifest that defines them shouldn't be installed in a zone, and if the manifests for these services are being installed within zones then that seems like a packaging bug. does what i'm saying make sense? i haven't looked at the other files yet, but i'll try to get to that tommorow. ed _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
