On Mon 09 Nov 2009 at 12:20PM, Jerry Jelinek wrote:
> Ed,
> 
> I've updated the code to address your comments.  A
> new webrev is posted at:
> 
> http://cr.opensolaris.org/~gjelinek/webrev.6793/

image_install: please add a header comment which explains what it does.

pkgcreatezone:136 everything besides OPT_V is named without the OPT_
prefix... and at a minimum shouldn't this be OPT_v?

src/brand/{pkgrm.lst,smf_disable.lst,...}  -- these files reference
"/etc/brand/native"-- is that right?

Any special handling needed for trusted?  You need to update the trusted
brand since you changed some of the hook arguments and command options.
It lives in src/util/distro-import/124/config.xml.

        -dp

-- 
Daniel Price, Solaris Kernel Engineering    http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to