Shawn Walker wrote: > I'm open to suggestions here, or I can revert to KNOWN if you think > that's acceptable.
I'd prefer KNOWN, particularly if the output of pkg list still has "known". > I was half tempted to use the state names in doc/pkg-states.txt :) > IN_CATALOG and OUT_CATALOG perhaps? Yeah, um. :) > >As far as the output of "pkg list" is concerned (and I think you're not > >changing that here, right?), please make sure Stephen is aware of any > >change you're making, as he's the one who designed the original, including > >the separation between the STATE and UFIX columns. > > We could honestly use the extra space for FMRIs (given our upcoming > rename), and since packages will have multiple states in the near > future, I think we should do that. I'm not opposed at all, but I'm not sure what Stephen's intent was here, if there even was any strong intent. > Hmm; currently it's a trivial wrapper (get_matching_fmris) and only > extract_matching_fmris is used anywhere (tests) so I went ahead and > replace get_matching_fmris calls with extract_matching_fmris > everywhere and dumped get_matching_fmris. Okay; I was thinking that extract_matching_fmris() could be dropped as well, if it's not being used in any production code. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
