Danek Duvall wrote:
Shawn Walker wrote:
http://cr.opensolaris.org/~swalker/pkg-cat-p2-3/v2-v3.patch
In client.py, you change img.PKG_STATE_INSTALLED to "installed". Why not
to img.IMG_CATALOG_INSTALLED?
Because this is a package state and not a catalog state?
Either way, I wanted to use a _()'d string.
I'm concerned that Image.find_root() is now expected to be slow enough to
need progress tracking. Is this just that you're potentially doing a
catalog upgrade at this point?
Currently, and there might be additional startup work we do in the
future that we want to be certain is progress tracked so that the user
isn't left wondering what the system is doing.
The comment "This stem has an installed version." on line 2063 of image.py
can now probably fit on a single line.
I'll make the changes you mentioned, and barring any objections or
unexpected problems, I'll putback later tonight.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
