Shawn Walker wrote: > http://cr.opensolaris.org/~swalker/pkg-cat-p2-3/v2-v3.patch
In client.py, you change img.PKG_STATE_INSTALLED to "installed". Why not to img.IMG_CATALOG_INSTALLED? I'm concerned that Image.find_root() is now expected to be slow enough to need progress tracking. Is this just that you're potentially doing a catalog upgrade at this point? Your inner function add_installed_entry() probably doesn't need to take the "path" argument, as that appears to be completely derivable from "self" and "f". The comment "This stem has an installed version." on line 2063 of image.py can now probably fit on a single line. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
