Padraig,
I suppose those are only preference options and the rest needs to be
implemented:
- not showing confirmation dialog on package removal
- showing confirmation dialog on pkg install/update
As far as I remember I volunteered for this task?
Also I don't like the text:
"Remember current state on exit"
It took me a while to figure out what this mean. I thought that this
will save currently selected category and package. I did figure this out
only after looking at the code:
"
165 + <short>Display previous package source at startup</short>
166 + <long>
167 + A boolean which determines whether Package Manager should
save
168 + its state on exit and use it on restart.
169 + </long>
"
So based on that I think this text should be changed to reflect that we
are storing the selected publisher (we agreed to name those publishers
not package sources).
best
Michal
Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-7029-v3/, fixes
7029 Allow use of previous publisher at start of Package Manager
This webrev updates the preferences dialog to add two new preferences:
Remember current state on exit
Show confirmation dialog on Install/Update
It also implements saving and restoring the current state if the
preference is enabled.
Displaying the confirmation dialog on Install/Update will be in a
separate webrev.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
