LGTM
Michal
Padraig O'Briain wrote:
I have respun the webrev,
http://cr.opensolaris.org/~padraig/ips-7029-v6/, to address Ann's
comment on the capitalization of Publisher.
Padraig
On 09/21/09 23:51, Ann Sunhachawee wrote:
Padraig O'Briain wrote:
On 09/18/09 15:57, Michal Pryc wrote:
Padraig,
I suppose those are only preference options and the rest needs to
be implemented:
- not showing confirmation dialog on package removal
- showing confirmation dialog on pkg install/update
As far as I remember I volunteered for this task?
Yes. I assumed that you will be eventually implementing these options.
Also I don't like the text:
"Remember current state on exit"
I respun the webrev,
http://cr.opensolaris.org/~padraig/ips-7029-v5/, so that the text
which appears on the screen is "Remember selected Publisher on exit".
I have also updated the preferences schema file to clarify what is
being saved.
Seems ok to me, except for the capitalization of "Publisher" , which
I don't think is correct in this context. Would use "publisher".
Ann
Padraig
It took me a while to figure out what this mean. I thought that
this will save currently selected category and package. I did
figure this out only after looking at the code:
"
165 + <short>Display previous package source at
startup</short>
166 + <long>
167 + A boolean which determines whether Package
Manager should save
168 + its state on exit and use it on restart.
169 + </long>
"
So based on that I think this text should be changed to reflect
that we are storing the selected publisher (we agreed to name those
publishers not package sources).
best
Michal
Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-7029-v3/, fixes
7029 Allow use of previous publisher at start of Package Manager
This webrev updates the preferences dialog to add two new
preferences:
Remember current state on exit
Show confirmation dialog on Install/Update
It also implements saving and restoring the current state if the
preference is enabled.
Displaying the confirmation dialog on Install/Update will be in a
separate webrev.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
