Shawn Walker <[email protected]> writes: > Stephen Hahn wrote: >> * Richard Lowe <[email protected]> [2009-10-06 04:45]: >>> Hey all, >>> >>> I'd like code review for: >>> 11735 pkg history data files should not be executable >>> >>> Webrev: >>> http://cr.opensolaris.org/~richlowe/pkg_11735 >> >> This fix looks good. (I am assuming there's no standard Python >> equivalent to the S_I[RWX]* macros from sys/stat.h.) > > Actually, their are, I had forgotten about that when Rich asked me to > peek at this before. This should give mode 644: > > stat.S_IRUSR|stat.S_IWUSR|stat.S_IRGRP|stat.S_IROTH
I updated the webrev (in place) with this change, and a similar change to use the symbolic modes in the mkdir call, above. The test of directory permissions is mostly pointless, and just there for completeness. Thanks, -- Rich _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
