Richard Lowe wrote:
Dan Price <[email protected]> writes:
license.py: is the variable "mode" actually needed? Seems
like this constant could just be passed to the later call to
os.chmod(path, mode) -> os.chmod(path, misc.PKG_RO_FILE_MODE)
t_catalog.py: perhaps import misc as misc, then reference it
that way? That would be more consistent with the rest of the code.
Otherwise, looks good.
Done as: http://cr.opensolaris.org/~richlowe/pkg_11735-3/
modules/actions/file.py:
line 209: no constant for this mode exists I'm assuming?
Can you file a separate bug titled something like:
mode usage should be consistent and centralized
...and add that to your commit comment?
Other than that, this seems right to me.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
