Richard Lowe <[email protected]> writes: > Dan Price <[email protected]> writes: > >> license.py: is the variable "mode" actually needed? Seems >> like this constant could just be passed to the later call to >> os.chmod(path, mode) -> os.chmod(path, misc.PKG_RO_FILE_MODE) >> >> t_catalog.py: perhaps import misc as misc, then reference it >> that way? That would be more consistent with the rest of the code. >> >> Otherwise, looks good. > > Done as: http://cr.opensolaris.org/~richlowe/pkg_11735-3/ > > I've left manifest.py as 'from pkg.misc import ...', since I don't think > prefixing EmptyI helps readability at all, shout if you want that > changed too.
I think the exported changeset attached should be ready to be integrated, if someone would be kind enough to do it for me. Sorry for the delay, and thanks. -- Rich
11735.diff.gz
Description: Binary data
_______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
