On Fri 09 Oct 2009 at 01:17PM, Shawn Walker wrote:
> Richard Lowe wrote:
> >Danek Duvall <[email protected]> writes:
> >
> >>Richard Lowe wrote:
> >>
> >>>I updated the webrev (in place) with this change, and a similar change
> >>>to use the symbolic modes in the mkdir call, above.
> >>I'm not seeing a change to misc.py to hold this group of constants. Are
> >>you working on that? If so, could you please wrap it into this wad, or
> >>make it a prerequisite of this wad?
> >
> >Sorry, I didn't see that entire subthread.
> >
> >http://cr.opensolaris.org/~richlowe/pkg_11735-2/
>
> Looks fine to me. Thanks again for doing this.
license.py: is the variable "mode" actually needed? Seems
like this constant could just be passed to the later call to
os.chmod(path, mode) -> os.chmod(path, misc.PKG_RO_FILE_MODE)
t_catalog.py: perhaps import misc as misc, then reference it
that way? That would be more consistent with the rest of the code.
Otherwise, looks good.
-dp
--
Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
