Thanks for taking a look Joanie much appreciated - comments below:
JR
Joanmarie Diggs wrote:
Hey John.
On Mon, 2009-11-02 at 17:29 +0000, jmr wrote:
Hi Joanie - here is a webrev that hopefully addresses your Webinstall issue.
I've just given it a few spins with my server and with contrib. I like
it. Thank you so much!
Cool :)
Observations/questions:
It notifies the user if a publisher with packages to install is disabled
(not packages to install its nothing to do). It lets them know they will
be enabled for install and disabled again on completion.
1. This dialog seems like another candidate for one of those "do not
show me this again" checkboxes. I realize that's a separate issue. But
when the confirmation dialogs get them, it would be nice if this dialog
could also be considered for one.
I think its a little too dangerous to enable a disabled publisher
without notifying the user. It is only a single return to get rid of it.
2. After the publisher has been enabled and the install/update proceeds,
the dialog displaying the progress and details lacks focus -- as does
the one which subsequently appears after a successful install. These
should have focus.
Strange I thought it had focus on my box, when I ran the test I can just
hit return to close the information dialog and then return again to
close the Installation Completed dialog, without ever clicking on the
dialogs. Will take a look at it tomorrow, not on a build machine atm.
3. The post-installation disabling of the publisher takes a while. Mind
you, it doesn't take any longer than it would if I were manually
disabling it within PM. But here's what I'm wondering: Presumably there
is a certain amount of, for lack of a better word, maintenance that
takes place when a user disables a publisher. Is that maintenance
necessary here? If it is, no big deal; if it's not, a quick re-disabling
of the publisher would make this even cooler.
Yep it does take a while, we are just calling the api, I assume the time
is being spent in refreshing the catalogs for the image which need to be
updated. Sorry about that, perhaps the IPS folks have some suggestions
to speed this up.
Any thoughts Shawn?
Still need to look at disabling on error conditions or after canceling,
may opt not to do this, not sure.
Thanks again. Take care.
--joanie
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
