On Tue, Dec 01, 2009 at 03:00:21PM -0700, Jerry Jelinek wrote:
> Edward Pilatowicz wrote:
> >On Thu, Nov 19, 2009 at 12:29:07PM -0700, Jerry Jelinek wrote:
> >>I have a proposed fix for:
> >>
> >>8878 cannot validate migration of ipkg zone
> >>
> >>This implements the dry-run detach and attach
> >>of an ipkg-branded zone. There is a webrev at:
> >>
> >>http://cr.opensolaris.org/~gjelinek/webrev.8878/
> >>
> >
> >i think this comment has been raised before, but could we please not
> >parse and generate xml files using nawk? ;) some other ideas for
> >making the changes you need are:
> >
> >- write a small python program that uses the python xml parser.
> >- create "zonecfg export" that exports your xml file.
>
> Ed,
>
> I've updated the proposed fix to address your comments above.
> There's a new webrev at:
>
> http://cr.opensolaris.org/~gjelinek/webrev.8878/
>
> Let me know if you have any other comments.
>
src/brand/Makefile:
- why
-I/usr/include/libxml2
instead of just
#include <libxml2/...>
src/brand/detach:
- perhaps i'm missing something obvious, but it looks to me like you
extract publisher information from the image and then never use it?
- the noexecute flag to the "support detach" callback is kinda
cheesy. how about doing "support detach -n".
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
