Ed,
Thanks for your extra comments, responses in-line.
Edward Pilatowicz wrote:
src/brand/Makefile:
- why
-I/usr/include/libxml2
instead of just
#include <libxml2/...>
Because the included header recursively includes other headers
which won't be found without that -I path. This is the same
technique as we use for the zones code in ON.
src/brand/detach:
- perhaps i'm missing something obvious, but it looks to me like you
extract publisher information from the image and then never use it?
Sorry, I'll clean up that cruft.
- the noexecute flag to the "support detach" callback is kinda
cheesy. how about doing "support detach -n".
OK, I'll change that.
Thanks,
Jerry
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
