Edward Pilatowicz wrote:
src/brand/Makefile:- why -I/usr/include/libxml2 instead of just #include <libxml2/...> src/brand/detach: - perhaps i'm missing something obvious, but it looks to me like you extract publisher information from the image and then never use it? - the noexecute flag to the "support detach" callback is kinda cheesy. how about doing "support detach -n".
Ed, I've updated the code to address your comments above. As per my response yesterday, I've left the Makefile as is. There is an updated webrev at: http://cr.opensolaris.org/~gjelinek/webrev.8878/ Let me know if you have any other comments. Thanks, Jerry _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
