On Thu, Dec 03, 2009 at 07:18:58PM -0800, Dan Price wrote: > On Thu 03 Dec 2009 at 09:54AM, Edward Pilatowicz wrote: > > On Thu, Dec 03, 2009 at 08:48:57AM -0700, Jerry Jelinek wrote: > > > Ed, > > > > > > I've updated the code to address your comments above. > > > As per my response yesterday, I've left the Makefile as is. > > > There is an updated webrev at: > > > > > > http://cr.opensolaris.org/~gjelinek/webrev.8878/ > > > > > > Let me know if you have any other comments. > > So this code seems to further propagate into more corners the > notion that everything we do revolves around 'entire'-- but > we know that's not right, and will break down pretty darn soon > when Liane puts back. >
yeah. that is covered here: 12738 zone install/attach incorporation logic needs enhancement http://defect.opensolaris.org/bz/show_bug.cgi?id=12738 > It seems to me that it'd be a lot better to let the manifest > carry along a blob of data which the packaging system gives > it-- perhaps inside of <[[CDATA, and then to give that > same blob back to the pkg system on the remote side. > > Otherwise, it seems like a pkg FMRI is a somewhat incomplete > identifier, since we lack any sort of publisher information with which > to give it context. It will work most of the time, but there seems > to be a nice chance here to better define the architectural > responsibilities for interpreting different aspects of the manifest. > so iirc the detach generated .xml file is designed so that we can quickly validate if an attach will work or not. curretnly the only thing we do during attach is sync entire, so this matches what we have today, but it is code that we'll end up ripping out when we fix 12738. so one different option would be to include a zone package inventory within the detach xml file. that would provide maximum flexibility when determing if we can attach the zone. (this inventory could probably be generated by a new option to pkg list.) if we decided todo this do you think that in addition to a listing all the pakcates we should also include publisher information? ed _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
