[email protected] wrote:
On Tue, Dec 15, 2009 at 07:31:50PM -0600, Shawn Walker wrote:
This was an additional call to stats.reset() that I'm doing *before*
pulling license actions, but after the manifest retrieval is done.
If this is happening after manifest retrieval and you're restting the
statistics again before downloading files, then this is probably fine.
Correct.
I can't seem to find a happy place to download the license data
before plan execution.
I'm generally happy with how this wad looks. I'm sorry if I was giving
you an impression to the contrary.
Not from you.
As I see it, the best option to avoid spreading transport error handling
around is to retrieval all of the license data during ImagePlan
evaluate() so that it is immediately available to the client should it
need to display it or if the user requests it.
However, Danek has expressed the concern that install shouldn't be
significantly noisier, and the current behaviour means that the user
ends up seeing two download phases.
This is more efficient and somewhat less confusing since any of the
licenses that were downloaded during evaluate() won't be included in the
total files that need to be downloaded during imageplan.preexecute().
The issue is that the client needs access to all of the license
information after plan creation (evaluation) and *before* plan execution
(when actual package files are downloaded).
Ideally, the client should be able to get at all of the license
information separately from all of the rest. In other words, something
like "image-update -n --licenses" should give them the license
information for all updated packages.
I originally had it setup to fetch the license text on demand, but as
you pointed out, that could open a slew of transport error handling
cases to deal with and its not very efficient.
So I'm not sure how to balance simplifying the retrieval of the licenses
while avoiding license retrieval unless necessary.
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
