[email protected] wrote:
On Tue, Dec 15, 2009 at 06:38:55PM -0600, Shawn Walker wrote:
[email protected] wrote:
On Tue, Dec 15, 2009 at 04:43:07PM -0600, Shawn Walker wrote:
full updated webrev:
http://cr.opensolaris.org/~swalker/pkg-license-2/
...
- lines 137-160: The transport should already create an opener for files
that it has successfully downloaded using the MFile interface. This
code should be simplified to check if the action's data attribute
exists and is callable. If it is, then that's the opener this call
should return. Otherwise, the license has already been installed
and you can create a local opener.
The only thing about that is that I have to wrap the opener again
with another opener since the data returned by that callable is gzip
compressed (I hope always).
If you don't want to re-wrap the opener, another possibility would be to
actually invoke the install() method of the license actions after you
download them. If they've been downloaded and installed, you're
guaranteed to have a decompressed local copy available.
I don't want to call the install() method as we've talked about changing
how and where license actions get installed. I also don't want to store
the decompressed version unless absolutely necessary.
If you decide to re-wrap the opener, please make the code be obvious
about what you're doing. My current project is to perform parallel
I've taken that route for the moment.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
