Shawn Walker wrote: > >api_errors.py: > > > > - line 76: why not just use **kwargs? > > Do you mean **kwargs literally (if so, how?) or do you mean why not > use keyword arguments instead of a dict that is passed in?
The latter. > >imageplan.py: > > > > - line 670: what does this have to do with the license stuff? > > My (perhaps naive) understanding was that I needed to do a transport > stats reset to ensure that download speeds during preexecute() were > correct. See lines 792-795. > > At the very least, it looks like I could remove 792-795 since I'm > doing this earlier. Okay; if johansen is comfortable with this, then I have no cause for concern. It just seemed out of place. > > - line 696: what does this look like on screen? Do we get two different > > lines of progress tracking? > > You'll see the download progress output once for the licenses, and > then again (assuming preexecute() succeeds) after that for the actual > package content. Each has their own completely separate headers, > etc. :( > This is the one bit I wasn't sure about how to make prettier or more > informative. Can you combine the two? That's what we have now, and it's just fine. Perhaps for licenses that don't need any treatment before further download, they can just be part of the normal download, while licenses that need to be accepted or viewed can be downloaded in a first step. (We can tweak later, too.) I don't want the typical install to get even noisier. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
