Danek Duvall wrote:
Shawn Walker wrote:
http://cr.opensolaris.org/~swalker/pkg-license-2/
Bug 13156 doesn't appear to be part of this changeset.
Yes, sorry. That was an intentional omission since the whole class
thing is starting to seem rather pointless/fuzzy. I had originally
implemented it, but then dumped it. All of the key functionality can be
delivered without it, so that seemed the best option for now. I'll
remove it from the changeset comments.
api_errors.py:
- line 76: why not just use **kwargs?
Do you mean **kwargs literally (if so, how?) or do you mean why not use
keyword arguments instead of a dict that is passed in?
imageplan.py:
- line 670: what does this have to do with the license stuff?
My (perhaps naive) understanding was that I needed to do a transport
stats reset to ensure that download speeds during preexecute() were
correct. See lines 792-795.
At the very least, it looks like I could remove 792-795 since I'm doing
this earlier.
- line 696: what does this look like on screen? Do we get two different
lines of progress tracking?
You'll see the download progress output once for the licenses, and then
again (assuming preexecute() succeeds) after that for the actual package
content. Each has their own completely separate headers, etc.
This is the one bit I wasn't sure about how to make prettier or more
informative.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
