On 01/20/10 07:07 AM, Tim Foster wrote:
Hi all,
I've got fixes for two bugs here that I'd appreciate a code review of
please:
http://cr.opensolaris.org/~timf/11554,13987-pkg-arg-checks
they're pretty minor changes I think, but comments welcome.
I'm not certain we should make the change for bug 11554.
If you look at the __set_ssl_cert() and __set_ssl_key() routines in
modules/client/publisher.py, it calls os.path.abspath() on the paths
provided to attempt to make them absolute for the user. I purposefully
intended for users to be able to specify relative paths.
I think the problem is that logic won't work since by the time we get to
the path bits, the working directory will have been changed and I
believe it relies on os.getcwd().
I wonder if resolving bug 8682 would be a better option instead.
As for bug 13987:
line 1893: Add a ", 1" to the split() to ensure we split a max of one time.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
