On 01/22/10 01:28 PM, Tim Foster wrote:
Hi Shawn,
On Fri, 2010-01-22 at 11:17 -0600, Shawn Walker wrote:
line 2368, 2370: instead of "if<var> and len(<var>)> 0" just use "if
<var> is not None" as everything else around it does
You're right, I misread the comment,
--
2353 # None is checked for here so that a client can unset a ssl_cert or
2354 # ssl_key by using -k "" or -c "".
thinking that ssl_cert was being set to '""' - sorry.
Python considers "" to be False when evaluated, so that wouldn't matter
either :)
I've updated the webrev at
http://cr.opensolaris.org/~timf/11554,13987-pkg-arg-checks
Seems right to me.
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
