On 01/20/10 03:34 PM, Brock Pytlik wrote:
Tim Foster wrote:
Hi all,
I've got fixes for two bugs here that I'd appreciate a code review of
please:
http://cr.opensolaris.org/~timf/11554,13987-pkg-arg-checks
they're pretty minor changes I think, but comments welcome.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
These changes look good to me. I think making the changes for 11554 now
make sense unless 8682 is going to land for this release. Since 8682
doesn't have an owner, I'm for integrating the fix for 11554 now, and it
can always be pulled out if 8682 comes in for a landing.
I'd rather see us turn the relative path into an absolute path using
os.path.normpath() and the working directory that was active at startup
before the Image() or ImageInterface() object is constructed.
The result of that can then be checked using os.path.abspath(), and then
we could error.
Either way, this is all moot once we change how certs/keys are stored.
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
