On Fri, 2010-01-22 at 13:45 -0600, Shawn Walker wrote: > On 01/22/10 01:28 PM, Tim Foster wrote: > > thinking that ssl_cert was being set to '""' - sorry. > > Python considers "" to be False when evaluated, so that wouldn't matter > either :)
Yep, absolutely. It was the os.path.isabs() check I was worried about though: that'd report False for a path of '""' so that's why I was checking for len(..) > 0. > > I've updated the webrev at > > http://cr.opensolaris.org/~timf/11554,13987-pkg-arg-checks > > Seems right to me. Great stuff - thanks for the review cheers, tim _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
