On 03/24/10 10:51 AM, Shawn Walker wrote:
On 03/24/10 12:48 PM, Liane Praza wrote:
On 03/24/10 10:25 AM, Shawn Walker wrote:
On 03/24/10 12:21 PM, Liane Praza wrote:
On 03/24/10 08:55 AM, Shawn Walker wrote:
On 03/24/10 03:06 AM, Liane Praza wrote:
Probably should file another bug to cover the publisher part of the
work
for this push too, but please take a look at my proposed importer
changes to allow RE to start using ON (and soon other) consolidation
repositories in 136.
http://cr.opensolaris.org/~lianep/pkg-re/
It's at line 64.
Yes, it's declared at line 64, but if you are assigning to the value of
a global, it has to be declared explicitly as global within a function
(e.g. main_func()) if you want it to affect the global, otherwise it's
treated as a local variable.
As such, I'm pretty sure that none of the assignments in main_func() are
actually changing the global's value. I don't know if that's intentional
or not, but it seems odd.
IIRC, now that I think about it a little bit, it's intentional. It seems
like I accidentally misused a global when I originally did this. The
fact that it's a global I believe has no effect.
I guess I can change it and see what breaks...
Ah. Well, if it shouldn't be the same as the global, I'd greatly
appreciate the name being changed to avoid another person thinking it
was a bug :)
I've gone back the other way on continued code inspection... the global
use in other places is to be able to print out sensible warnings. I doubt
a package constructed like this would need to use those globals, but it's
possible and might be confusing if others were added in the future. I'll
add the global to main_func(), though it should have no effect now.
(Bart -- commentary if I'm being silly is appreciated.)
liane
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
