On 03/24/10 12:08 PM, Liane Praza wrote: > On 03/24/10 09:21 AM, Mark J. Nelson wrote: >> src/util/distro-import/Makefile >> - Since IPS is also a consolidation that may ultimately deliver via >> repository, should IPS_CONSOLIDATION_OPTIONS be CONSOLIDATION_OPTIONS? > > OK.
Cool. >> src/util/publish/set-publisher.sh >> - Should publisher be hardcoded to opensolaris.org, or configurable? > > It'd have to be configurable by rewriting the transform, and, um, ugh. Defer? Transforms can, I believe, reference macros. :) But I don't mind deferring at all--getting this working for the primary use case is paramount, generalizing it is not. >> src/util/publish/set-publisher.transforms >> - Seems like this is a good place to use a regular expression? Ie don't >> you want all of the resulting packages to get the opensolaris.org >> publisher, regardless of whence they come? > > I think that's sensible, as long as I can always assume the publisher is set. > > <transform set -> edit value pkg://[^/]+/ pkg://opensolaris.org/> Right now that seems safe, but I don't know if that's by design or happenstance. Further, I think you want a "name=pkg.fmri" qualifier for this transform, too. We don't currently match that expression anywhere else, but it still seems sensible to constrain the actions that match the transform. You could even test for the publisher setting, but I'm not actually sure what the fmri would look like without it? <transform set name=pkg.fmri value=pkg://[^/]+/.+ -> edit value ....> ? I'm also OK deferring this part, too, if you think the changes call for a bit more thought. --Mark _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
