On 03/24/10 02:33 PM, Liane Praza wrote: > On 03/24/10 12:59 PM, Mark J. Nelson wrote: >> On 03/24/10 12:08 PM, Liane Praza wrote: >>> On 03/24/10 09:21 AM, Mark J. Nelson wrote: > >>>> src/util/publish/set-publisher.transforms >>>> - Seems like this is a good place to use a regular expression? Ie don't >>>> you want all of the resulting packages to get the opensolaris.org >>>> publisher, regardless of whence they come? >>> >>> I think that's sensible, as long as I can always assume the publisher is >>> set. >>> >>> <transform set -> edit value pkg://[^/]+/ pkg://opensolaris.org/> >> >> Right now that seems safe, but I don't know if that's by design or >> happenstance. >> >> Further, I think you want a "name=pkg.fmri" qualifier for this >> transform, too. We don't currently match that expression anywhere else, >> but it still seems sensible to constrain the actions that match the >> transform. > > I've settled on this for now. > > <transform set name=pkg.fmri -> > edit value pkg://[^/]+/ pkg://opensolaris.org/>
LGTM. I feel so trendy with the acronyms. --Mark _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
