On 03/24/10 12:21 PM, Liane Praza wrote:
On 03/24/10 08:55 AM, Shawn Walker wrote:
On 03/24/10 03:06 AM, Liane Praza wrote:
Probably should file another bug to cover the publisher part of the work
for this push too, but please take a look at my proposed importer
changes to allow RE to start using ON (and soon other) consolidation
repositories in 136.
http://cr.opensolaris.org/~lianep/pkg-re/
This paves the way for the rest of the 136 sync, I believe. There's also
likely some more work to be done here, but this does allow generation of
a combined repository.
Not necessarily directly related...
src/util/distro-import/importer.py:
line 1250: not used
Isn't that a bug, not something that should just be removed? Not sure
I'm prepared to tackle the testing for this one right now.
That's fine.
line 1287: missing "global curpkg" ? (see lines 1532-1567)
It's at line 64.
Yes, it's declared at line 64, but if you are assigning to the value of
a global, it has to be declared explicitly as global within a function
(e.g. main_func()) if you want it to affect the global, otherwise it's
treated as a local variable.
As such, I'm pretty sure that none of the assignments in main_func() are
actually changing the global's value. I don't know if that's
intentional or not, but it seems odd.
-Shawn
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
