On Mon, Jun 28, 2010 at 11:01:37PM -0700, Shawn Walker wrote:
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-format/
Just a few nits.
depot.py:
- line 342: typo, should be "ll_mirror"
modules/config.py:
- Could you add some more documentation to this module? I'm not
really sure what all of these different property classes do.
It would be nice to knoe more about the overall design for this
configuration format too.
- line 1173: If both the encode and decode fail, this will append the
original value of 'v' to nvalue. Is this the desired behavior for
this failure case?
Thanks,
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
